DEV-7091 – TaxCloud: shipping, address, and cache fixes#20
Merged
azane-code merged 2 commits intomasterfrom Mar 11, 2026
Merged
DEV-7091 – TaxCloud: shipping, address, and cache fixes#20azane-code merged 2 commits intomasterfrom
azane-code merged 2 commits intomasterfrom
Conversation
…preservation, and cache key order
…, cache key after event
GusOhnesorge
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three issues reported by Polydigitech: TaxCloud not capturing shipping cost, full address missing in captured transactions (wrong county/tax), and test lookups not matching captured orders due to cache key timing.
Changes
1. Shipping fallback when $0 (
Model/Api.php)lookupTaxes(), when the shipping tax-detail row total is 0 (e.g. cart before shipping method is selected), use$address->getShippingAmount()so TaxCloud receives the actual shipping amount.2. Preserve street after address verification (
Observer/Sales/Address.php)verifyAddress()returns emptyAddress1, keep the originalAddress1/Address2so the street isn’t dropped and county/tax stay correct (e.g. Fulton vs Gwinnett for 30097).3. Cache key from post-observer params (
Model/Api.php)taxcloud_lookup_beforebefore computing the cache key so the key is based on the same params sent to TaxCloud (including any observer changes). Avoids serving stale cache for a different address.